[webkit-reviews] review granted: [Bug 5825] Use SharedPtr throughout KSVG2 : [Attachment 4797] Remove all ref()/deref() calls, replace with SharedPtr usage

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Nov 25 06:31:37 PST 2005

Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 5825: Use SharedPtr throughout KSVG2

Attachment 4797: Remove all ref()/deref() calls, replace with SharedPtr usage

------- Additional Comments from Darin Adler <darin at apple.com>
Looks great. There is an argument for SharedPtr<DOMStringImpl> over DOMString
-- you should talk with Maciej about it when you have a chance.

The lazy_create template function looks like it's being used in quite a few
places where there's already a 0 check on the parameter. I don't see how the
function is better than a call to new in such places, now that there's no need
for a call to ref(). In fact, I can't see a single place in this patch where
lazy_create is making the code bettter. SVGStyledElementImpl::className is
close, but the cast makes it not as good as the old code in my opinion.

More information about the webkit-reviews mailing list