[webkit-reviews] review granted: [Bug 5687] inline more ScopeChain functions for speed : [Attachment 4650] make more functions inline for speed

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Nov 24 12:12:26 PST 2005


Eric Seidel <macdome at opendarwin.org> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 5687: inline more ScopeChain functions for speed
http://bugzilla.opendarwin.org/show_bug.cgi?id=5687

Attachment 4650: make more functions inline for speed
http://bugzilla.opendarwin.org/attachment.cgi?id=4650&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
The code looks fine.  However while you're in there, you might as well clean up
the formatting of ScopeChain::bottom() (spacing) and ScopeChain::pop() (one
line if) to follow our published coding guidelines.



More information about the webkit-reviews mailing list