[webkit-reviews] review denied: [Bug 5192] WebKit+SVG is missing support for many Filter Elements : [Attachment 4739] more lighting

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Nov 23 04:23:28 PST 2005

Eric Seidel <macdome at opendarwin.org> has denied Oliver Hunt
<ojh16 at student.canterbury.ac.nz>'s request for review:
Bug 5192: WebKit+SVG is missing support for many Filter Elements

Attachment 4739: more lighting

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
We've dicsussed this some over irc, issues include:

* copyright headers
* some code could be shorter:
+    CIFilter *filter;
+    filter = [[self alloc] init];
+    return [filter autorelease];
* newlines:
\ No newline at end of file
* no need for this header:
+#import <stdio.h>

I believe there were other things we discussed via irc.

More information about the webkit-reviews mailing list