[webkit-reviews] review denied: [Bug 5701] elementAtPoint: does not return NSString for WebElementLinkTargetFrameKey : [Attachment 4671] patch to correctly return target string in elementAtPoint:

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Terrence Talbot
<ttalbot at karelia.com>'s request for review:
Bug 5701: elementAtPoint: does not return NSString for
WebElementLinkTargetFrameKey
http://bugzilla.opendarwin.org/show_bug.cgi?id=5701

Attachment 4671: patch to correctly return target string in elementAtPoint:
http://bugzilla.opendarwin.org/attachment.cgi?id=4671&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
The documentation is incorrect; the code is correct. The frame itself is what's
in the dictionary, not the name.

Making this change would break Safari.

Whoever wrote the documentation was presumably confused by the fact that
WebCore passes up the name of the frame in the dictionary.

We could perhaps add a new field with the name of the target frame, but we
can't change WebElementLinkTargetFrameKey in this way.