[webkit-reviews] review denied: [Bug 4726] Drop of multiple non-image file URLs only yields one item : [Attachment 4696] Proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Nov 16 22:14:20 PST 2005

Maciej Stachowiak <mjs at apple.com> has denied Andrew Wellington
<proton at wiretapped.net>'s request for review:
Bug 4726: Drop of multiple non-image file URLs only yields one item

Attachment 4696: Proposed patch

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Looks like a generally good fix. But, two comments.

In TextEdit, the paths end up separated by newlines, not spaces. So it would be
better to use "\n" as the separator instead of " ", for consistency. Second,
what happens if you have a mix of image and non-image URLs? Seems to me like
with this code, you'd lose the non-image paths still.

And finally, as a matter of style, shouldn't the support for non-image types be
right in _documentFragmentWithPaths:, instead of in a separate else case? That
would also make it easier to handle a mix of image and non-image types.

Great first cut, please make these revisions and it will be read to land I

More information about the webkit-reviews mailing list