[webkit-reviews] review denied: [Bug 5680] containsOnlyWhitespace does not need to be a virtual function : [Attachment 4643] remove virtual containsOnlyWhitespace from DOM::NodeImpl

[bugzilla-request-daemon at opendarwin.org]

Eric Seidel <macdome at opendarwin.org> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 5680: containsOnlyWhitespace does not need to be a virtual function
http://bugzilla.opendarwin.org/show_bug.cgi?id=5680

Attachment 4643: remove virtual containsOnlyWhitespace from DOM::NodeImpl
http://bugzilla.opendarwin.org/attachment.cgi?id=4643&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
This part of your patch is not safe:

+		  !curr->element() || !static_cast<TextImpl
*>(curr->element())-

It may be possible for things other than TextNodes to create RenderText objects
(at least in an SVG-enabled world).