[webkit-reviews] review granted: [Bug 5686] maked Shared::deref
faster by eliminating multiple branches :
[Attachment 4649] get rid of the double if statement in deref without
changing semantics
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Wed Nov 9 12:15:36 PST 2005
Eric Seidel <macdome at opendarwin.org> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 5686: maked Shared::deref faster by eliminating multiple branches
http://bugzilla.opendarwin.org/show_bug.cgi?id=5686
Attachment 4649: get rid of the double if statement in deref without changing
semantics
http://bugzilla.opendarwin.org/attachment.cgi?id=4649&action=edit
------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
The ref changes look fine. Changing RenderWidget not to be a subclass of
Shared seems a bit unnecessary (all the Shared functions are inline to begin
with), but it's not a big deal either.
More information about the webkit-reviews
mailing list