[webkit-reviews] review granted: [Bug 5172] Bidi algorithm not
applied correctly across line breaks :
[Attachment 4608] Alternative patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sat Nov 5 17:22:09 PST 2005
Darin Adler <darin at apple.com> has granted opendarwin.org at mitzpettel.com's
request for review:
Bug 5172: Bidi algorithm not applied correctly across line breaks
http://bugzilla.opendarwin.org/show_bug.cgi?id=5172
Attachment 4608: Alternative patch
http://bugzilla.opendarwin.org/attachment.cgi?id=4608&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
I would suggest using SharedPtr for m_lineBreakContext and for the context
field of BidiState.
This patch looks greate otherwise, although I think the real proof is in the
test cases, r=me.
More information about the webkit-reviews
mailing list