[webkit-reviews] review denied: [Bug 5602] REGRESSION: RegExp("[^\\s$]+", "g") returns extra matches : [Attachment 4572] patch to set lastIndex properly, fixes test case

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Nov 2 21:56:39 PST 2005


Geoffrey Garen <ggaren at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 5602: REGRESSION: RegExp("[^\\s$]+", "g") returns extra matches
http://bugzilla.opendarwin.org/show_bug.cgi?id=5602

Attachment 4572: patch to set lastIndex properly, fixes test case
http://bugzilla.opendarwin.org/attachment.cgi?id=4572&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
lastIndex + foundIndex + match.size() should be foundIndex + match.size() --
was that a typo?



More information about the webkit-reviews mailing list