[webkit-reviews] review denied: [Bug 3298] insertRow generates DOM Exception if TABLE does not possess a TBODY : [Attachment 2710] Patch for new testcase

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Justin Garcia
<justin.garcia at apple.com>'s request for review:
Bug 3298: insertRow generates DOM Exception if TABLE does not possess a TBODY
http://bugzilla.opendarwin.org/show_bug.cgi?id=3298

Attachment 2710: Patch for new testcase
http://bugzilla.opendarwin.org/attachment.cgi?id=2710&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
The patch looks like a step in the right direction, but I have at least these
concerns:

    1) There's no test case where we call insertRow in the case where there
actually is content. To be truly convinced we don't need the hasChildNodes()
check I'd like to see test cases with <tr>, <td>, and other actual body
elements, and know they did the right thing (whatever that is).
    2) The test case doesn't test what insertRow did, it just checks for
success or failure of the call. I think if we're verifying that a <tbody> is
added, we should somehow check that.
    3) All the test cases fail on Firefox, which worries me.

Given these, I'm going to mark this review- until we investigate a bit further.