[webkit-reviews] review granted: [Bug 3760] Add iterator support to HashSet : [Attachment 2700] patch to add iterator stuff

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Jun 29 08:20:51 PDT 2005

Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 3760: Add iterator support to HashSet

Attachment 2700: patch to add iterator stuff

------- Additional Comments from Darin Adler <darin at apple.com>
Not sure why HashSet::KeyType is private.

Maybe I'm remembering this wrong, but I thought that if you want to omit
postfix ++, you need to declare it privately and not define it. Otherwise, it
will just use the prefix ++?

No need for the extra parentheses in this:

+	 while (m_position != m_endPosition &&
(m_table->isEmptyBucket(*m_position))) {


More information about the webkit-reviews mailing list