[webkit-reviews] review granted: [Bug 3743] Incorrect error message given for certain calls : [Attachment 2689] Reformatted patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Jun 28 10:46:40 PDT 2005

Darin Adler <darin at apple.com> has granted Oliver Hunt
<ojh16 at student.canterbury.ac.nz>'s request for review:
Bug 3743: Incorrect error message given for certain calls

Attachment 2689: Reformatted patch

------- Additional Comments from Darin Adler <darin at apple.com>
The patch looks fine.

The layout test needs work, though, because it doesn't say what it's testing,
nor describe the expected results. In fact, it's actively misleading because it
talks about testing Array.toString with deep hierarchies, which is not the

I'll set review+ on this, but we shouldn't land it until we have an improved
layout test.

More information about the webkit-reviews mailing list