[webkit-reviews] review denied: [Bug 3298] insertRow generates DOM Exception if TABLE does not possess a TBODY : [Attachment 2672] Update firstBody accordingly

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Anders Carlsson <andersca at mac.com>'s
request for review:
Bug 3298: insertRow generates DOM Exception if TABLE does not possess a TBODY
http://bugzilla.opendarwin.org/show_bug.cgi?id=3298

Attachment 2672: Update firstBody accordingly
http://bugzilla.opendarwin.org/attachment.cgi?id=2672&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I think hasChildElements belongs in either NodeImpl or ElementImpl rather than
here.

No need to check hasChildNodes() in hasChildElement(). firstChild() will be 0,
and the function will quickly return false without the extra check.

I think a better approach to tracking firstBody would be to hold a ref to
firstBody, then check if its parent is still "this" in childrenChanged, and
deref it if so. Also deref in the destructor of course. No need to override
removeChild.