[webkit-reviews] review denied: [Bug 3477] some US-centric date formats not parsed by JavaScript (clock at news8austin.com) : [Attachment 2635] Next interation of proposed fix

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Carsten Guenther
<cguenther at gmail.com>'s request for review:
Bug 3477: some US-centric date formats not parsed by JavaScript (clock at
news8austin.com)
http://bugzilla.opendarwin.org/show_bug.cgi?id=3477

Attachment 2635: Next interation of proposed fix
http://bugzilla.opendarwin.org/attachment.cgi?id=2635&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This line:

+  return seconds == -1 ? NaN : seconds * 1000.0;

should use the constant "invalidDate" rather than a hard-wired -1.

Otherwise, r=me, assuming that our testing is super-thorough. Ideally I'd want
a test date that exercises each branch within the date-parsing function.

Enabling the date tests in the Mozilla JavaScript test suite is a great idea.
I'm so happy this change will allow us to do that!

Harri Porten also showed me a pretty complete date test page the other day. I
suggest contacting him, because I'd like to land that as a layout test.