[webkit-reviews] review denied: [Bug 3274] document() not supported
: [Attachment 2605] Adress comments
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Thu Jun 23 23:10:59 PDT 2005
Darin Adler <darin at apple.com> has denied Anders Carlsson <andersca at mac.com>'s
request for review:
Bug 3274: document() not supported
http://bugzilla.opendarwin.org/show_bug.cgi?id=3274
Attachment 2605: Adress comments
http://bugzilla.opendarwin.org/attachment.cgi?id=2605&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
I'd prefer that the layout test explain what it's testing and what the expected
result is.
There's some formatting strangeness here -- space after xmlSetGenericErrorFunc
but before the parenthesis.
Also there are break statements after return statements, which seems
unnecessary to me.
Should fix typo: "somwhere".
Otherwise, looks good.
More information about the webkit-reviews
mailing list