[webkit-reviews] review denied: [Bug 3674] GW: Add CGPoint and other small fixes to KWQPoint* : [Attachment 2604] Formatting oversights now fixed.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Jun 23 22:57:43 PDT 2005


Darin Adler <darin at apple.com> has denied Eric Seidel <macdome at opendarwin.org>'s
request for review:
Bug 3674: GW: Add CGPoint and other small fixes to KWQPoint*
http://bugzilla.opendarwin.org/show_bug.cgi?id=3674

Attachment 2604: Formatting oversights now fixed.
http://bugzilla.opendarwin.org/attachment.cgi?id=2604&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Forward declaration of class QRect should be at the top of the file.

No space after "-=" in operator -= declaration.

When importing things in the KWQ directory, don't use forwarding headers. Hence
it should be:

    #import "KWQRect.h"

Otherwise, looks fine.



More information about the webkit-reviews mailing list