[webkit-reviews] review denied: [Bug 3667] Core JavaScript 1.5 Reference:Objects:Array:forEach : [Attachment 2598] Revised patch that adds forEach Javascript 1.5 functionality to JavascriptCore

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Francisco Tolmasky
<tolmasky at gmail.com>'s request for review:
Bug 3667: Core JavaScript 1.5 Reference:Objects:Array:forEach
http://bugzilla.opendarwin.org/show_bug.cgi?id=3667

Attachment 2598: Revised patch that adds forEach Javascript 1.5 functionality
to JavascriptCore
http://bugzilla.opendarwin.org/attachment.cgi?id=2598&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
A few tiny code formatting issues.

There should only be one space after the colon (":  args[1]").

There should not be a space after the parenthesis in the for.

The if statement is formatting incorrectly:

    if (exec->hadException())

the above is correct style. Patch otherwise looks great!