[webkit-reviews] review denied: [Bug 3673] GW: Add QBuffer::setBuffer(QByteArray) support to KWQBuffer : [Attachment 2589] Formatting oversights now fixed.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Jun 23 10:01:42 PDT 2005

Darin Adler <darin at apple.com> has denied Eric Seidel <macdome at opendarwin.org>'s
request for review:
Bug 3673: GW: Add QBuffer::setBuffer(QByteArray) support to KWQBuffer

Attachment 2589: Formatting oversights now fixed.

------- Additional Comments from Darin Adler <darin at apple.com>
The parameter to the QBuffer constructor should be QByteArray, not QByteArray
&, to match Qt.

If it's going to be a reference, then I suggest that we make it const
QByteArray & and do the same with the parameter to setBuffer.

Otherwise, looks good.

More information about the webkit-reviews mailing list