[webkit-reviews] review denied: [Bug 3670] GW: Add remove and byteOrderMark support to KWQString for kdom : [Attachment 2574] Adds remove() and byteOrderMark support to KWQString

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Jun 23 07:08:23 PDT 2005


Darin Adler <darin at apple.com> has denied Eric Seidel <macdome at opendarwin.org>'s
request for review:
Bug 3670: GW: Add remove and byteOrderMark support to KWQString for kdom
http://bugzilla.opendarwin.org/show_bug.cgi?id=3670

Attachment 2574: Adds remove() and byteOrderMark support to KWQString
http://bugzilla.opendarwin.org/attachment.cgi?id=2574&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Formatting is incorrect in the definitions of "remove". There are extra spaces
before the "(" and ")" characters.

Also, there's no need for "this->" in the implenetations of those methods.



More information about the webkit-reviews mailing list