[webkit-reviews] review granted: [Bug 3477] some US-centric date formats not parsed by JavaScript (clock at news8austin.com) : [Attachment 2552] Changes without indentation cleanup

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Carsten Guenther
<cguenther at gmail.com>'s request for review:
Bug 3477: some US-centric date formats not parsed by JavaScript (clock at
news8austin.com)
http://bugzilla.opendarwin.org/show_bug.cgi?id=3477

Attachment 2552: Changes without indentation cleanup
http://bugzilla.opendarwin.org/attachment.cgi?id=2552&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Patch looks great now.

I think we need a better test case now, that covers a lot more cases that the
single test case attached to this bug.

Perhaps we can find one the KDE project is already using? Or maybe with these
changes we can enable the Mozilla date tests.

In any case, the only remaining issue here is that the test case is not good
enough. I will mark this review+, but we should get a much more thorough test
case that covers the new code paths before we land this patch.

In particular, my insistence that we check errno may have resulted in a
stricter function that behaves different than KDE's KJS on various date
strings, so we might end up deciding we need to change that.