[webkit-reviews] review denied: [Bug 3416] Scroll bars are sometimes not updated properly : [Attachment 2543] Proposed patch (seems to improve the situation at least somewhat)

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Adam Schenker
<aschenke at tampabay.rr.com>'s request for review:
Bug 3416: Scroll bars are sometimes not updated properly
http://bugzilla.opendarwin.org/show_bug.cgi?id=3416

Attachment 2543: Proposed patch (seems to improve the situation at least
somewhat)
http://bugzilla.opendarwin.org/attachment.cgi?id=2543&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
The -[WebDynamicScrollBarsView initWithFrame:] part of this patch is definitely
wrong. All instance variables in Objective-C start with 0, so there's no need
to write code to set inUpdateScrollers to false.

The change to not use inUpdateScrollers in WebDynamicScrollBarsView is
definitely wrong. The whole reason that boolean exists is to prevent reentrancy
that causes even more problems.

I'm not as sure, though, about the KHTMLView changes. I'll wait to hear what
Dave Hyatt has to say about those.

We're definitely not going to commit a patch based on guesswork without some
clearer idea of exactly what it does fix. In particular, we need an example of
at least one set of reproducible steps that failed before and now works with a
patch before we'd even consider it.