[webkit-reviews] review denied: [Bug 3317] REGRESSION: CSS2: outline is applied to both <li> element and its enclosing text with context dependent selector : [Attachment 2463] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jun 19 21:41:30 PDT 2005


Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 3317: REGRESSION: CSS2: outline is applied to both <li> element and its
enclosing text with context dependent selector
http://bugzilla.opendarwin.org/show_bug.cgi?id=3317

Attachment 2463: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=2463&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This patch is incorrect and will break all non-auto outline styles on inlines.

The real bug occurs in render_line.cpp around line 754.  Root lines should not
be adding their block objects to the outlineObjects dict.



More information about the webkit-reviews mailing list