[webkit-reviews] review denied: [Bug 3344] 10.3.9 Build Failure: isnan failure in kjs_window.cpp : [Attachment 2308] proposed fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Jun 18 16:53:21 PDT 2005

Darin Adler <darin at apple.com> has denied Finlay Dobbie <snu at opendarwin.org>'s
request for review:
Bug 3344: 10.3.9 Build Failure: isnan failure in kjs_window.cpp

Attachment 2308: proposed fix

------- Additional Comments from Darin Adler <darin at apple.com>
I don't like solutions that involve changing the project file, because it makes
it likely that we'll never remember to remove the hack. Also, setting the
internal _GLIBCPP flag in the project file is not how the library's intended to
be used.

There must be some other solution to compiling this on Panther. I'd prefer
another approach.

If we search and can't come up with anything, then feel free to set the review
flag on this patch again and I'll reconsider.

More information about the webkit-reviews mailing list