[webkit-reviews] patch to Bug #3317

Hanspeter Schaub HanspeterSchaub at mac.com
Sat Jun 18 12:35:00 PDT 2005

Regarding the Bug #3317 which states that Safari 1.3/2.0 started to  
incorrectly draw outlines.  I've uploaded a proposed patch which  
appears to fix this issue.  The recompiled webkit with this patch  
passes all the previous regression testing.  I've also uploaded a new  
regression test which highlights the list element outline issue.

Please note that I'm not a professional programmer, but an engineer.   
I found this fix by searching through all the source code for  
anything that effected the CSS outline property.  Through lots of  
tests, I then found that this line in renderflow.cpp caused the  
issue.  In the patch I simply commented it out.  I couldn't find any  
case where outlines were not drawn correctly now.   But, this is  
doesn't mean that this code didn't have some other purpose to be there.


Hanspeter Schaub

Hanspeter Schaub

Phone:     (540) 763-8370
Email:    HanspeterSchaub at mac.com
Web:    http://homepage.mac.com/hanspeterschaub

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20050618/1e65984b/attachment.html

More information about the webkit-reviews mailing list