[webkit-reviews] review granted: [Bug 3586] Setting and getting title's text attribute does not work : [Attachment 2435] Reset value of dumpTitleChanges after each run

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Jun 17 10:04:48 PDT 2005


Darin Adler <darin at apple.com> has granted Anders Carlsson <andersca at mac.com>'s
request for review:
Bug 3586: Setting and getting title's text attribute does not work
http://bugzilla.opendarwin.org/show_bug.cgi?id=3586

Attachment 2435: Reset value of dumpTitleChanges after each run
http://bugzilla.opendarwin.org/attachment.cgi?id=2435&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This looks fine. I think it would be even more elegant to figure out a way to
add this without a new method.

For example, any "unexpected" title changes could be logged. Perhaps the code
could check to see if the <title> element, if any, was parsed, and simply dump
all title changes after that point.

But I also think it's fine to land this as-is.

r=me



More information about the webkit-reviews mailing list