[webkit-reviews] review granted: [Bug 3503] form.elements[] not order-preserving when using javascript DOM interface : [Attachment 2389] New patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson <andersca at mac.com>'s
request for review:
Bug 3503: form.elements[] not order-preserving when using javascript DOM
interface
http://bugzilla.opendarwin.org/show_bug.cgi?id=3503

Attachment 2389: New patch
http://bugzilla.opendarwin.org/attachment.cgi?id=2389&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

Minor comments:

1) No need to have an else after a return in getFormElementIndex.

2) To make things possibly more robust I suggest that
HTMLFormElementImpl::registerFormElement do the check this way:

    if (i < 0 || i >= (int)formElements.count())

If we like we could assert to catch problems with incorrect indices.