[webkit-reviews] review granted: [Bug 3481] form elements added via innerHTML are not accessible via xpath style syntax : [Attachment 2329] Possible solution

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Niels Leenheer (rakaz)
<niels.leenheer at gmail.com>'s request for review:
Bug 3481: form elements added via innerHTML are not accessible via xpath style
syntax
http://bugzilla.opendarwin.org/show_bug.cgi?id=3481

Attachment 2329: Possible solution
http://bugzilla.opendarwin.org/attachment.cgi?id=2329&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Patch looks fine, aside from a couple minor stylistic issues:

1) We don't normally mark our local variables const even though I understand
that there is a slight value in doing so to clarify that they can never be
modified.

2) We don't normally put the * next to the type, although I don't know if the
coding style document mentions this.

3) I personally prefer the style where the declaration is inside the if for
code like this.

4) We would normally name this "newForm" rather than "newform", preferring the
"intercap" style to the "smush words together" style.

Anyway, that's all trivia: r=me.