[webkit-reviews] review granted: [Bug 3408] Safari 2.0 crashes on an accesskey associated with a button : [Attachment 2210] Fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Jun 16 09:41:08 PDT 2005


Darin Adler <darin at apple.com> has granted Anders Carlsson <andersca at mac.com>'s
request for review:
Bug 3408: Safari 2.0 crashes on an accesskey associated with a button
http://bugzilla.opendarwin.org/show_bug.cgi?id=3408

Attachment 2210: Fix
http://bugzilla.opendarwin.org/attachment.cgi?id=2210&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Good fix. It's very strange that this code, appropriate for <input
type=button>, was put here inside the <button> element implementation.

I prefer to completely eliminate the HTMLButtonElementImpl::click function,
however, rather than simply removing its "guts". So ideally someone landing
this would go that extra step.



More information about the webkit-reviews mailing list