[webkit-reviews] review denied: [Bug 3405] Replace Id for tag names
with QualifiedName :
[Attachment 2369] Second pass at QualifiedName and HTMLNames classes
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Wed Jun 15 14:04:27 PDT 2005
Darin Adler <darin at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 3405: Replace Id for tag names with QualifiedName
http://bugzilla.opendarwin.org/show_bug.cgi?id=3405
Attachment 2369: Second pass at QualifiedName and HTMLNames classes
http://bugzilla.opendarwin.org/attachment.cgi?id=2369&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Should use hasOneRef() instead of refCount() == 1; it's supposed to be for just
this sort of thing.
I still think you can use a namespace, regardless of the "factory" issue.
Namespaces can have functions in them too. The only reason to have a class is
if you want to create instances. No benefit to using a class to group a set of
global functions.
Anyway, r=me.
More information about the webkit-reviews
mailing list