[webkit-reviews] review denied: [Bug 3293] Object.prototype.hasOwnProperty() missing : [Attachment 2286] Updated implementation that handles special properties correctly

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jun 13 23:34:24 PDT 2005


Darin Adler <darin at apple.com> has denied Mark Rowe (bdash)
<opendarwin.org at bdash.net.nz>'s request for review:
Bug 3293: Object.prototype.hasOwnProperty() missing
http://bugzilla.opendarwin.org/show_bug.cgi?id=3293

Attachment 2286: Updated implementation that handles special properties
correctly
http://bugzilla.opendarwin.org/attachment.cgi?id=2286&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
ObjectImp::hasProperty that takes an integer needs to call through to
hasOwnProperty that takes an integer; it's important to stay in the integer
code path until you get to the array implementation of hasOwnProperty.

Other than that, this patch looks good.



More information about the webkit-reviews mailing list