[webkit-reviews] Patch to fix initialization issues in the
seiryu at comcast.net
Sun Jun 12 16:21:15 PDT 2005
On Jun 12, 2005, at 4:38 PM, Darin Adler wrote:
>> 1. did not properly initialize the superclass,
> This sounds like an important issue. Where did you discover this?
The -[WebViewPrivate init] method as it exists in CVS isn't
initializing the superclass at all AFAICT.
> By adding error handling for a condition that is never true, this
> creates code paths that can never be exercised. So I think that
> arguably it does not make the code better.
According to <http://developer.apple.com/documentation/Cocoa/
Conceptual/CodingGuidelines/Articles/FrameworkImpl.html> (see "Error
Detection During Initialization") it is important.
> I like the suggestion of using:
> if (!self)
> return nil;
> It would cause fewer changes and make it easier to merge patches
> with this change. I'd like to see a patch that does it this way.
OK, will do.
S/MIME signature available upon request
More information about the webkit-reviews