[webkit-reviews] Fix for regression on apple dashboard download page

Chris Blumenberg cblu at apple.com
Sun Jun 12 13:33:48 PDT 2005


Maciej and I talked about this on iChat for a little while. We agree  
that this is the right change to make. Since this change may affect  
the sequence of calls to the WebFrameLoadDelegate, testing of 3rd  
party apps should be done. CC'ing Adele so she's aware of this.

r=me

--- chris


On Jun 12, 2005, at 3:03 AM, Maciej Stachowiak wrote:

>
> http://bugzilla.opendarwin.org/show_bug.cgi?id=3445
>
> Layout tests pass. I did not add a new one because I could not  
> think of an obvious way to make a layout test do a download without  
> using a remote resource.
>
>
> <db-download-fix.patch.txt>
>
> I'm not sure this totally clears up the timing of when closeURL  
> gets called, I think it still happens twice on a navigation, but  
> this should keep you from ending up with a dead page when you click  
> on a download link.
>
> Regards,
> Maciej
>
> _______________________________________________
> webkit-reviews mailing list
> webkit-reviews at opendarwin.org
> http://www.opendarwin.org/mailman/listinfo/webkit-reviews
>




More information about the webkit-reviews mailing list