[webkit-reviews] Patch to fix initialization issues in the WebView subproj

Nicholas Shanks contact at nickshanks.com
Sun Jun 12 13:27:47 PDT 2005


On 12 Jun 2005, at 20:14, Nick Zitzmann wrote:

> When I first downloaded WebKit, I noticed there were a number of  
> classes in the WebView subproject that either:
> 1. did not properly initialize the superclass,
> 2. did not set self to the return value of the superclass, or
> 3. did not check to see if the superclass initializer actually  
> returned anything, or
> 4. a combination of all 3 of the above.

I prefer to use "if (!self) return nil;" rather than wrapping  
everything in the init method in an "if (self)" block - it would have  
made the patch a bit smaller too, but good work :)

- Nick.




More information about the webkit-reviews mailing list