[webkit-reviews] Bug #3370: Page renders in the top portion of the page...

Darin Adler darin at apple.com
Thu Jun 9 06:11:50 PDT 2005

On Jun 9, 2005, at 5:48 AM, Niels Leenheer wrote:

> I attached a patch to solve bug #3370:
> http://bugzilla.opendarwin.org/show_bug.cgi?id=3370

Excellent. Looks good to me.

The new code should match our coding guidelines, even if code around  
it doesn't. So we should remove the excess spaces inside the if  

And we definitely need a layout test case. Once someone addresses the  
minor formatting issue and adds a layout test, I'll be happy to land  
this fix.

     -- Darin

PS: There are a few other things we might do to improve the code  
slightly. It's nicer looking and even more efficient to do this:

+            if (*prev == ''%') {

There's no reason to cast a char to a QChar just to compare it with  
another QChar. I know that's just copied and pasted from code a  
couple lines above, but it's still a bit ugly. We could also avoid a  
bunch of irritating type casts if we just change the parameter of the  
function from unsigned int to int.

More information about the webkit-reviews mailing list