[webkit-reviews] Bug 3330 Fix

[Maciej Stachowiak]

On Jun 8, 2005, at 9:55 PM, Timothy Hatcher wrote:

> - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3330
> and <rdar://problem/4063841>
> REGRESSION (125-300): JavaScript "children" array includes all  
> descendants, not just immediate children
>
> <3330.patch>

Thanks for the patch. The code change looks good to me. Here's my  
comments:

1) Please put the else clause on a separate line from the "else"  
keyword as the coding style guidelines ask.

2) Can you please include a layout test in the patch, which confirms  
that the bug is fixed? You can probably base it on the the test case  
mentioned in the patch, and just put it in WebCore/layout-tests/fast/ 
dom, only adding stuff to the DOM as the output instead of relying on  
alerts. It's also good for layout tests to have a block at the top  
that says what the expected results should look like in a browser.

3) Did you run the existing layout tests with run-webkit-tests? (To  
avoid being asked this for future patches you can mention in email or  
bugzilla that you already ran them.)

Regards,
Maciej


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20050608/1f182a1a/attachment.html