[webkit-reviews] [Bug 3327] [PATCH] Exception When Setting Style to Invalid Value Lacks Line/File Information

Maciej Stachowiak mjs at apple.com
Tue Jun 7 22:07:40 PDT 2005

On Jun 7, 2005, at 8:24 PM, Mark Rowe wrote:

> Hi all,
> I've attached a patch to bug 3327* which to attach line number +  
> file information to some Javascript exceptions that previously  
> lacked them.   It only changes the KJS_CHECKEXCEPTIONVALUE case in  
> nodes.cpp, leaving KJS_CHECKEXCEPTIONREFERENCE and  
> KJS_CHECKEXCEPTION.  These macros may also need similar changes,  
> but as I couldn't create a small test case for either I left them  
> unchanged.

Hi Mark,

I reviewed your patch and it looks great. Can you tell me what kind  
of testing you did? (I know our automated test scripts haven't been  
working so great for open source development so I can run the mozilla  
JS tests and the layout tests for you if you need me to.) Also, as it  
might be nice to put the results of exec->exception().toObject(exec)  
into a local variable rather than doing it twice, just to avoid  
repeating the work. Can you attach a new patch with that change? If  
you do that and tell me about testing, then r=me and I'll commit it  
for you.


More information about the webkit-reviews mailing list