[webkit-reviews] review denied: [Bug 3473] Preloaded Image objects .src field is not a fully resolved path : [Attachment 2501] Bug fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Jul 29 10:57:21 PDT 2005


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 3473: Preloaded Image objects .src field is not a fully resolved path
http://bugzilla.opendarwin.org/show_bug.cgi?id=3473

Attachment 2501: Bug fix
http://bugzilla.opendarwin.org/attachment.cgi?id=2501&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
In the future, please attach patches as unified format diffs (the "-u") option
to diff.

We want to use stick to our coding style guidelines for new code, which means
it should say "(str)" instead of "( str )".

The reason we have to null-check the document is that the image object might
outlast the document; you can hold a reference to the image forever even if the
window is closed.

We also need a layout test to check in along with the bug fix.

But the logic of the fix looks great, r=me on that.



More information about the webkit-reviews mailing list