[webkit-reviews] review granted: [Bug 4156] svg2png testing tool for SVG : [Attachment 3131] Improved svg2png, better conforms to webkit coding style.

[bugzilla-request-daemon at opendarwin.org]

Maciej Stachowiak <mjs at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 4156: svg2png testing tool for SVG
http://bugzilla.opendarwin.org/show_bug.cgi?id=4156

Attachment 3131: Improved svg2png, better conforms to webkit coding style.
http://bugzilla.opendarwin.org/attachment.cgi?id=3131&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
+APPLE PUBLIC SOURCE LICENSE

Should use BSD, not APSL.

+	     } else if ([argString hasPrefix:@"--parser"]) {
+		 // ignored.
+	     } else if ([argString hasPrefix:@"--device"]) {
+		 // ignored.

May as well remove these unless KDE compat is really important.

+	     } else if ([argString isEqualToString:@"--dump"]) {

Perhaps it would be  better to require both input and output file as arguments,
the case of omitting --dump seems like it won't be handled well.

+			 NSLog(@"WARNING: did you mean to dump to: @  Or did
you just forget the --dump argument?", outputPath);

I think you meant %@ not just @

The mixing of char * and NSString * in the argument processing seems a little
weird.

r=me assuming you fix the license, do whatever you want on the other stuff.