[webkit-reviews] review denied: [Bug 3759] Date object enhancements : [Attachment 3093] Final patch

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Carsten Guenther
<cguenther at gmail.com>'s request for review:
Bug 3759: Date object enhancements
http://bugzilla.opendarwin.org/show_bug.cgi?id=3759

Attachment 3093: Final patch
http://bugzilla.opendarwin.org/attachment.cgi?id=3093&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks great. Excellent work and a nice solution.

Formatting issues (minor):

    1) Calls to and definition of time_from_args need the space removed between
the name of the function and the (.

    2) Our usual naming scheme is timeFromArgs, numArgs, maxArgs.

    3) There is still some stuff in this patch that is a whitespace change
only.

Test issue:

    1) I'd like to see a test that tests the milliseconds behavior, since an
earlier version of the patch had that wrong.

I'm really tempted to set this to review+, since it's almost perfect, but I'm
going to be principled and set this to review-.