[webkit-reviews] review denied: [Bug 3759] Date object enhancements : [Attachment 3020] Fixed above concerns

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 3759: Date object enhancements
http://bugzilla.opendarwin.org/show_bug.cgi?id=3759

Attachment 3020: Fixed above concerns
http://bugzilla.opendarwin.org/attachment.cgi?id=3020&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks great, overall, but a few loose ends.

There should be a space after the comma in:

    roundValue(exec,args[0]);

and the other places where roundValue calls were added.

The implementation of setSeconds sets the millseconds 0 when no milliseconds
are supplied. Instead it should preserve the existing milliseconds unless
milliseconds are passed explicitly. Same for setMinutes, setHours, etc. We need
test cases that would detect these problems and we should fix the patch too.

There are too many lines here with just whitespace changes; that's particularly
inconvenient since I have some global change patches outstanding, and any
whitespace-only change will create a merge conflict for my patch.