[webkit-reviews] review denied: [Bug 3759] Date object enhancements : [Attachment 3009] Fixed default path in DateObjectImp::construct

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Jul 19 11:56:59 PDT 2005


Geoffrey Garen <ggaren at apple.com> has denied Carsten Guenther
<cguenther at gmail.com>'s request for review:
Bug 3759: Date object enhancements
http://bugzilla.opendarwin.org/show_bug.cgi?id=3759

Attachment 3009: Fixed default path in DateObjectImp::construct
http://bugzilla.opendarwin.org/attachment.cgi?id=3009&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
This should fix the regression, but the switch statement and the comment are
still misleading:

1. We *do* know what to do -- it's explained clearly in the spec.

2. There are only two possible cases, not four: (1) type == string: call parse;
(2) else: call x.toPrimitive().toNumber()



More information about the webkit-reviews mailing list