[webkit-reviews] review denied: [Bug 4013] text find doesn't wrap
in PDF files : [Attachment 2976] proposed patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Fri Jul 15 14:31:04 PDT 2005
John Sullivan <sullivan at apple.com> has denied Trey Matteson <trey at usa.net>'s
request for review:
Bug 4013: text find doesn't wrap in PDF files
http://bugzilla.opendarwin.org/show_bug.cgi?id=4013
Attachment 2976: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=2976&action=edit
------- Additional Comments from John Sullivan <sullivan at apple.com>
Rather than retain, I'd suggest using -copy on savedSelection, because the
lifetime of a PDFSelection seems somewhat murky (calling [PDFSubview
currentSelection] twice in a row returns the same object each time,
surprisingly).
Otherwise, this seems good. Please explain how you tested it.
More information about the webkit-reviews
mailing list