[webkit-reviews] review granted: [Bug 3940] Many layout tests fail, one crashes : [Attachment 2899] the fix

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jul 10 11:50:54 PDT 2005


John Sullivan <sullivan at apple.com> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 3940: Many layout tests fail, one crashes
http://bugzilla.opendarwin.org/show_bug.cgi?id=3940

Attachment 2899: the fix
http://bugzilla.opendarwin.org/attachment.cgi?id=2899&action=edit

------- Additional Comments from John Sullivan <sullivan at apple.com>
Is the ptr[0] check an unnecessary premature optimization? Seems OK either way,
but I would have thought strcmp would be just as fast.

r=me assuming you tested performance or are completely confident that this
won't affect performance.



More information about the webkit-reviews mailing list