[webkit-reviews] review granted: [Bug 3405] Replace Id for tag names with QualifiedName : [Attachment 2873] Patch that addresses some of maciej's comments and includes his hash fixes

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Jul 9 01:12:22 PDT 2005


Maciej Stachowiak <mjs at apple.com> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 3405: Replace Id for tag names with QualifiedName
http://bugzilla.opendarwin.org/show_bug.cgi?id=3405

Attachment 2873: Patch that addresses some of maciej's comments and includes
his hash fixes
http://bugzilla.opendarwin.org/attachment.cgi?id=2873&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me with the following caveats:

1) I think the implicit conversions on QualifiedName are dangerous and could
lead to people getting themselves in trouble.

2) Please add a layout test for the behavior change on tag name validation
(maybe something that uses a tag name wiht _ or * in it).



More information about the webkit-reviews mailing list