[webkit-reviews] review granted: [Bug 3847] GW: add Cap support to QRegExp : [Attachment 2785] a little more tricky than some, but should still be easily understandable

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Jul 7 21:34:06 PDT 2005


Maciej Stachowiak <mjs at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 3847: GW: add Cap support to QRegExp
http://bugzilla.opendarwin.org/show_bug.cgi?id=3847

Attachment 2785: a little more tricky than some, but should still be easily
understandable
http://bugzilla.opendarwin.org/attachment.cgi?id=2785&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

Make sure to test performance before landing.

minor style nitpick: we prefer no braces around single-line if bodies. Please
fix that before landing.



More information about the webkit-reviews mailing list