[webkit-reviews] review denied: [Bug 3849] GW: Add T *QPtrDict::operator()() : [Attachment 2787] self explanitory patch.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jul 4 18:42:06 PDT 2005


Maciej Stachowiak <mjs at apple.com> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 3849: GW: Add T *QPtrDict::operator()()
http://bugzilla.opendarwin.org/show_bug.cgi?id=3849

Attachment 2787: self explanitory patch.
http://bugzilla.opendarwin.org/attachment.cgi?id=2787&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Eric and I discussed this and agreed it is probably a bad idea to iterate over
a dictionary this way, instead of using an iterator, so better to fix the
caller.



More information about the webkit-reviews mailing list