[webkit-reviews] review denied: [Bug 3828] GW: add QTime::addMSecs() suppport and currentTime() support to KWQ : [Attachment 2767] self explanitory patch.

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Jul 3 03:02:55 PDT 2005


Maciej Stachowiak <mjs at apple.com> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 3828: GW: add QTime::addMSecs() suppport and currentTime() support to KWQ
http://bugzilla.opendarwin.org/show_bug.cgi?id=3828

Attachment 2767: self explanitory patch.
http://bugzilla.opendarwin.org/attachment.cgi?id=2767&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
This appears buggy. It seems to add msecs to the default time rather than the
current time.  One way around this would be to copy-construct QTime from *this,
and since the default time value is 0 this is quite likely wrong.



More information about the webkit-reviews mailing list