[webkit-reviews] review granted: [Bug 4557] rename unusual strcmp and strcasecmp for DOMString family : [Attachment 5361] eliminate strcmp, and replace strcasecmp with equalIgnoringCase

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Dec 30 02:16:09 PST 2005


Maciej Stachowiak <mjs at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 4557: rename unusual strcmp and strcasecmp for DOMString family
http://bugzilla.opendarwin.org/show_bug.cgi?id=4557

Attachment 5361: eliminate strcmp, and replace strcasecmp with
equalIgnoringCase
http://bugzilla.opendarwin.org/attachment.cgi?id=5361&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me but please consider the comment above. Also, perhaps ALLOC_QCHAR_VEC and
DELETE_QCHAR_VEC could be given normal looking function names now, as long as
you are renaming them.



More information about the webkit-reviews mailing list