[webkit-reviews] review granted: [Bug 6297] XMLSerializer should use createMarkup : [Attachment 5375] Fix some bugs in createMarkup, and make xmlserializer use it

[bugzilla-request-daemon at opendarwin.org]

Eric Seidel <macdome at opendarwin.org> has granted Anders Carlsson
<andersca at mac.com>'s request for review:
Bug 6297: XMLSerializer should use createMarkup
http://bugzilla.opendarwin.org/show_bug.cgi?id=6297

Attachment 5375: Fix some bugs in createMarkup, and make xmlserializer use it
http://bugzilla.opendarwin.org/attachment.cgi?id=5375&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
We talked about this on irc.  You were going to rename escapeHTML to something
like escapeTextForMarkup when landing.

Also, I'm not 100% convinced that we really have enough XMLSerializer tests to
know that this change won't break anything.

Finally, this might have changed one more test case xsltprocessor.html which
should be testing for a document fragment containing only a text node (6180 I
think?).

Assuming you feel the test cases are sufficent, r=me.  Thanks for another great
patch!