[webkit-reviews] review granted: [Bug 6259] Handle negative, FP numbers with non-10 radix in toString : [Attachment 5309] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Dec 28 21:23:38 PST 2005

Maciej Stachowiak <mjs at apple.com> has granted Maks Orlovich <maksim at kde.org>'s
request for review:
Bug 6259: Handle negative, FP numbers with non-10 radix in toString

Attachment 5309: patch

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I'll grant review because I think  it's better to have this change than not.

> +	 const double eps = 0.001; // TODO: guessed. base on radix ?

That seems like a pretty high value for epsilon.

> int(d)
> double(radix)

(in various places) - it would be better to avoid this cast syntax for numbers,
I think. In some cases I think it is unnecesary, in other cases a normal
c-style cast or assigning first to a variable of the appropriate type would be

I think these improvements can be made in a separate pass though.

More information about the webkit-reviews mailing list